Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised Abaqus interface #24

Merged
merged 15 commits into from
May 30, 2024
Merged

Optimised Abaqus interface #24

merged 15 commits into from
May 30, 2024

Conversation

tmnp19
Copy link
Collaborator

@tmnp19 tmnp19 commented May 28, 2024

  • Optimised the way the field outputs are written and treated inside piglot. Now piglot only writes the fields and the set names that are present in the YAML file and automatically extrapolates to nodes units that are calculated at the integration points;
  • Added errors to check for non-linear fields in linear simulations;
  • Fixed some bugs on the implementation of the selected instance on abaqus;
  • Generalised the reading of Abaqus input fiiles.

@tmnp19 tmnp19 requested a review from ruicoelhopedro May 28, 2024 22:32
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.61%. Comparing base (7f7f27a) to head (9e82563).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   93.61%   93.61%           
=======================================
  Files          27       27           
  Lines        2131     2131           
=======================================
  Hits         1995     1995           
  Misses        136      136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruicoelhopedro ruicoelhopedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort, these are nice improvements. I've left some minor comments that should be quick to address. We should be able to merge this quickly.

piglot/solver/abaqus/fields.py Show resolved Hide resolved
piglot/solver/abaqus/reader.py Outdated Show resolved Hide resolved
piglot/solver/abaqus/reader.py Show resolved Hide resolved
piglot/solver/abaqus/solver.py Outdated Show resolved Hide resolved
@tmnp19 tmnp19 requested a review from ruicoelhopedro May 30, 2024 00:27
Copy link
Member

@ruicoelhopedro ruicoelhopedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I'll get this merged. Thanks for the work!

@ruicoelhopedro ruicoelhopedro merged commit a4458fa into main May 30, 2024
11 checks passed
@ruicoelhopedro ruicoelhopedro mentioned this pull request Jul 22, 2024
ruicoelhopedro added a commit that referenced this pull request Jul 22, 2024
### Improvements
- Add a flag to pass extra arguments to ABAQUS #18
- Add CUDA support for BoTorch #19
- Silence unsafe YAML loader warning #21
- Optimise ABAQUS interface #24
- Generalise reading of ABAQUS input data #25 
- Introduce the review from JOSS submission #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants