Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests were broken on Catch3 #896

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

henryiii
Copy link
Collaborator

These were invalid on an imported target (and was incorrect anyway).

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (dce7983) 99.46% compared to head (80d5461) 99.46%.

❗ Current head 80d5461 differs from pull request most recent head 4aec706. Consider uploading reports for the commit 4aec706 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #896   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          18       18           
  Lines        4095     4095           
=======================================
  Hits         4073     4073           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/tests_catch3 branch from 80d5461 to 4aec706 Compare June 28, 2023 19:16
@henryiii
Copy link
Collaborator Author

FYI, I think this was introduced in #804.

@henryiii henryiii merged commit c8cd053 into main Jun 28, 2023
@henryiii henryiii deleted the henryiii/fix/tests_catch3 branch June 28, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant