Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#76 | Remove "is required" string passed as an argument to RequiredEr… #77

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

RecklessTodd
Copy link

…ror() constructor to avoid double printing.

The string "is required" is already added internally by RequiredError() class.

…quiredError() constructor to avoid double printing.

The string "is required" is already added internally by RequiredError() class.
@codecov
Copy link

codecov bot commented Feb 11, 2018

Codecov Report

Merging #77 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #77   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1365   1284   -81     
=====================================
- Hits         1365   1284   -81
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afde0b0...9de1a88. Read the comment docs.

@henryiii henryiii merged commit 4e62a0a into CLIUtils:master Feb 12, 2018
@henryiii
Copy link
Collaborator

Thanks! Was left over from the old way of adding strings.

@henryiii henryiii added this to the v1.4 milestone Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants