Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Macros.hpp include to Error.hpp #755

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

thewtex
Copy link
Contributor

@thewtex thewtex commented Jul 5, 2022

To address:

In file included from /ITKWebAssemblyInterface/include/itkPipeline.h:21:
In file included from /ITKWebAssemblyInterface-build/_deps/cli11-src/include/CLI/App.hpp:25:
In file included from /ITKWebAssemblyInterface-build/_deps/cli11-src/include/CLI/ConfigFwd.hpp:17:
/ITKWebAssemblyInterface-build/_deps/cli11-src/include/CLI/Error.hpp:75:5: error: unknown type name 'CLI11_NODISCARD'
    CLI11_NODISCARD int get_exit_code() const { return actual_exit_code; }
    ^

thewtex and others added 2 commits July 4, 2022 21:25
To address:

```
In file included from /ITKWebAssemblyInterface/include/itkPipeline.h:21:
In file included from /ITKWebAssemblyInterface-build/_deps/cli11-src/include/CLI/App.hpp:25:
In file included from /ITKWebAssemblyInterface-build/_deps/cli11-src/include/CLI/ConfigFwd.hpp:17:
/ITKWebAssemblyInterface-build/_deps/cli11-src/include/CLI/Error.hpp:75:5: error: unknown type name 'CLI11_NODISCARD'
    CLI11_NODISCARD int get_exit_code() const { return actual_exit_code; }
    ^
```
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #755 (57b03d6) into main (65ef491) will not change coverage.
The diff coverage is n/a.

❗ Current head 57b03d6 differs from pull request most recent head 119f79e. Consider uploading reports for the commit 119f79e to get more accurate results

@@           Coverage Diff           @@
##             main     #755   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          12       12           
  Lines        3958     3958           
=======================================
  Hits         3937     3937           
  Misses         21       21           
Impacted Files Coverage Δ
include/CLI/Error.hpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65ef491...119f79e. Read the comment docs.

@henryiii henryiii merged commit c57000e into CLIUtils:main Jul 5, 2022
@henryiii
Copy link
Collaborator

henryiii commented Jul 5, 2022

Thanks!

@github-actions github-actions bot added needs changelog Hasn't been added to the changelog yet needs README Needs to be mentioned in the README labels Jul 5, 2022
@henryiii henryiii removed the needs README Needs to be mentioned in the README label Sep 14, 2022
@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants