Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving error messages definitions to Error.h #60

Merged
merged 6 commits into from
Nov 29, 2017
Merged

Moving error messages definitions to Error.h #60

merged 6 commits into from
Nov 29, 2017

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Nov 28, 2017

This cleans up the rest of the message to make localization easier (still not explicitly included, but easier when most of the localized text is in one place!). This probably is the last PR to 1.3.

This also gives options an inheritable ->configurable(false) setting, to allow the user to exclude some options from the ini file.

The add config has been renamed to set_config, and calling it with no arguments clears the config option.

@henryiii henryiii added this to the v1.3 milestone Nov 28, 2017
@codecov
Copy link

codecov bot commented Nov 28, 2017

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #60   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           9      9           
  Lines        1296   1342   +46     
  Branches      248    251    +3     
=====================================
+ Hits         1296   1342   +46
Impacted Files Coverage Δ
include/CLI/Ini.hpp 100% <100%> (ø) ⬆️
include/CLI/Error.hpp 100% <100%> (ø) ⬆️
include/CLI/App.hpp 100% <100%> (ø) ⬆️
include/CLI/Split.hpp 100% <100%> (ø) ⬆️
include/CLI/Option.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e01d2...7726dc2. Read the comment docs.

@henryiii henryiii merged commit 45520a0 into master Nov 29, 2017
@henryiii henryiii deleted the errmsgs branch November 29, 2017 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant