Policies #59
Merged
Policies #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1280 1296 +16
Branches 246 248 +2
=====================================
+ Hits 1280 1296 +16
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1280 1296 +16
Branches 246 248 +2
=====================================
+ Hits 1280 1296 +16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds explicit policies for what to do with multiple options passed. The default is to throw if an argument is passed multiple times, but
take_last,take_first, andjoinare all available. Take last is common in many apps.joinis used (*) forgit commit -m "one" -m "two".expected(-1)and join them yourself afterwards, so custom join strings were not added.Also, AppVeyor now is required to pass before merging, as well.
See #39 and #38. Also #48. This should behave just like the original fix, with the exception that
get_take_lastis no longer available and you cannot give an argument totake_last.MultiOptionPolicy::Throwremains the default (see #58), but you only have to set this once before setting up your app options and subcommands:app.option_defaults()->take_last();