create pkg-config file #523
Conversation
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 3740 3740
=========================================
Hits 3740 3740 Continue to review full report at Codecov.
|
cmake/CLI11GeneratePkgConfig.cmake
Outdated
| set(DEST_DIR "${CMAKE_INSTALL_PREFIX}") | ||
| set(PACKAGE_VERSION "${VERSION_STRING}") | ||
|
|
||
| CONFIGURE_FILE("cmake/CLI11.pc.in" "CLI11.pc" @ONLY) |
There was a problem hiding this comment.
| CONFIGURE_FILE("cmake/CLI11.pc.in" "CLI11.pc" @ONLY) | |
| configure_file("cmake/CLI11.pc.in" "CLI11.pc" @ONLY) |
cmake/CLI11GeneratePkgConfig.cmake
Outdated
| @@ -0,0 +1,9 @@ | |||
| set(DEST_DIR "${CMAKE_INSTALL_PREFIX}") | |||
| set(PACKAGE_VERSION "${VERSION_STRING}") | |||
There was a problem hiding this comment.
Why not use @PROJECT_VERSION@ (which is automatically set by CMake), and just use it inside the .pc.in file? And use @CMAKE_INSTALL_PREFIX@ too? If this is a convention, it could stay that way, but others, it seems to be simpler without adding new variables?
There was a problem hiding this comment.
Just ignorance on my part of CMake. I've pushed a version with your suggestions.
7731a73 to
724f6ad
Compare
|
Thanks! |
Create a pkg-config metadata file so that CLI11 can be found by pkg-config