-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to customize help flag. #43
Conversation
18610aa
to
3b67be7
Compare
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1168 1174 +6
Branches 239 240 +1
=====================================
+ Hits 1168 1174 +6
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1171 1179 +8
Branches 240 242 +2
=====================================
+ Hits 1171 1179 +8
Continue to review full report at Codecov.
|
Does it really need to throw if the help pointer is already set? Couldn't it just deregister the old help pointer instead? That way, someone who just wants to change the help string or flag name doesn't have to know about the |
Other than the answer to that question, it looks good. I added a |
Deregistering would be better, but I don't know how to do that :) |
Okay, I can add that, just a second.. |
adaba5b
to
aba829b
Compare
Thanks! |
Another little helper: Allows to customize the help flag without fully exposing help_ptr_. This makes it possible to translate the string, for example. Inspired by taywee/args.