Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option check method error #320

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Option check method error #320

merged 1 commit into from
Sep 20, 2019

Conversation

fpeng1985
Copy link
Contributor

the validator is added using "push_back", but the name is set to the front of validators_, which i think is a mistake~

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #320 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #320   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3038   3038           
=====================================
  Hits         3038   3038
Impacted Files Coverage Δ
include/CLI/Option.hpp 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09c169c...67501fc. Read the comment docs.

@henryiii henryiii merged commit 8ecce8f into CLIUtils:master Sep 20, 2019
@henryiii
Copy link
Collaborator

Thanks!

@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants