-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Third stage callback #313
Third stage callback #313
Conversation
I want to see where additional test coverage is needed for this PR, so I think it ready for review, but I will probably need to add some more tests yet. |
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3017 3027 +10
=====================================
+ Hits 3017 3027 +10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 12 12
Lines 3028 3038 +10
=====================================
+ Hits 3028 3038 +10
Continue to review full report at Codecov.
|
add test from readme about callbacks update callback documentation, add a subbcommand immediate_callback test add third callback and readme update
4af6d49
to
627837a
Compare
I think everything is ready to go here. I left |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would really benefit from having the tutorial book updated. I'll try to merge that into CLI11 in the next week or two.
Co-Authored-By: Henry Schreiner <HenrySchreinerIII@gmail.com>
Keeping the book up to date will probably be a lot easier once it is merged. I know I would be more inclined to update that if it was in a single repository. |
If merged this PR will add a third callback to apps.
Based on the discussion from gitter
It adds two new function
final_callback
andparse_complete_callback
The `callback function will populate one of these depending on the status of immediate_callaback. immediate_callback will also toggle between them if one is empty. The default is routing to final_callback which has the same behavior as prior to the PR.Some thoughts about deprecating the immediate_callback but losing it would remove capabilities at present, so I don't think it should be deprecated yet at least until the callback function itself is deprecated.