Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning in header in MSVC #157

Closed
chfast opened this issue Aug 30, 2018 · 2 comments
Closed

Warning in header in MSVC #157

chfast opened this issue Aug 30, 2018 · 2 comments
Labels
planned

Comments

@chfast
Copy link
Contributor

chfast commented Aug 30, 2018 

c:\.hunter\_base\15e27f2\4668f98\6a3ff3d\install\include\cli\configfwd.hpp(120): warning C4458: declaration of 'items' hides class member [C:\projects\evmc\build\test\vmtester\evmc-vmtester.vcxproj]
  c:\.hunter\_base\15e27f2\4668f98\6a3ff3d\install\include\cli\configfwd.hpp(63): note: see declaration of 'CLI::Config::items'
@henryiii
Copy link
Collaborator

The warning is correct, we need to rename the variable in that function.

henryiii added a commit that referenced this issue Sep 3, 2018
@henryiii
Fix for warnings in MSVC #157
1d41d14
henryiii added a commit that referenced this issue Sep 3, 2018
@henryiii
Fix for warnings in MSVC #157
a5d2684
henryiii added a commit that referenced this issue Sep 3, 2018
@henryiii
Fix for warnings in MSVC #157
0cb3959
@henryiii
Copy link
Collaborator

henryiii commented Sep 3, 2018

Please verify this is now fixed in master through #159.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
planned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chfast @henryiii