Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/trained models inference #226

Merged
merged 22 commits into from
Apr 13, 2022
Merged

Feature/trained models inference #226

merged 22 commits into from
Apr 13, 2022

Conversation

djaniak
Copy link
Collaborator

@djaniak djaniak commented Mar 31, 2022

No description provided.

@djaniak djaniak self-assigned this Mar 31, 2022
@netlify
Copy link

netlify bot commented Mar 31, 2022 •
edited
Loading

✅ Deploy Preview for embeddingsclarinpl canceled.

Name Link
🔨 Latest commit 2566140
🔍 Latest deploy log https://app.netlify.com/sites/embeddingsclarinpl/deploys/6256c248fdac7000097e203f

@djaniak djaniak temporarily deployed to Test deployment March 31, 2022 12:04 Inactive
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@djaniak djaniak temporarily deployed to Test deployment March 31, 2022 16:10 Inactive
@djaniak djaniak marked this pull request as ready for review April 4, 2022 20:36
@djaniak djaniak requested review from asawczyn and ktagowski and removed request for asawczyn April 5, 2022 09:13
@djaniak djaniak force-pushed the feature/trained-models-inference branch from 8be0dcf to 6f56da7 Compare April 5, 2022 13:23
@djaniak djaniak temporarily deployed to Test deployment April 5, 2022 14:13 Inactive
@ktagowski Review Notebook App
Copy link
Collaborator

ktagowski commented Apr 5, 2022 •
edited
Loading

Added comments to https://app.reviewnb.com/CLARIN-PL/embeddings/blob/feature/trained-models-inference/notebooks/validate_flair_models_inference.ipynb//discussion/

@ktagowski Review Notebook App
Copy link
Collaborator

Added comments to https://app.reviewnb.com/CLARIN-PL/embeddings/blob/feature/trained-models-inference/notebooks/validate_lightning_models_inference.ipynb/

asawczyn
asawczyn requested changes Apr 6, 2022
View reviewed changes
embeddings/pipeline/lightning_classification.py Outdated Show resolved Hide resolved
embeddings/pipeline/lightning_sequence_labeling.py Outdated Show resolved Hide resolved
embeddings/task/lightning_task/text_classification.py Outdated Show resolved Hide resolved
notebooks/validate_flair_models_inference.ipynb Outdated Show resolved Hide resolved
notebooks/validate_lightning_models_inference.ipynb Outdated Show resolved Hide resolved
@djaniak djaniak force-pushed the feature/trained-models-inference branch from c1dbe65 to 0766e3a Compare April 7, 2022 12:39
@djaniak djaniak temporarily deployed to Test deployment April 7, 2022 23:47 Inactive
ktagowski
ktagowski requested changes Apr 8, 2022
View reviewed changes
notebooks/validate_flair_models_inference.ipynb Outdated Show resolved Hide resolved
notebooks/validate_flair_models_inference.ipynb Outdated Show resolved Hide resolved
@djaniak djaniak force-pushed the feature/trained-models-inference branch from fc6ae13 to 8ef0b25 Compare April 8, 2022 14:08
@djaniak djaniak requested review from ktagowski and asawczyn April 8, 2022 14:44
@djaniak djaniak force-pushed the feature/trained-models-inference branch from f6b9ad5 to a218b96 Compare April 9, 2022 12:37
@djaniak djaniak force-pushed the feature/trained-models-inference branch from a218b96 to 8434919 Compare April 10, 2022 17:52
@djaniak djaniak temporarily deployed to Test deployment April 10, 2022 20:21 Inactive
ktagowski
ktagowski previously approved these changes Apr 11, 2022
View reviewed changes
asawczyn
asawczyn requested changes Apr 11, 2022
View reviewed changes
embeddings/data/datamodule.py Outdated Show resolved Hide resolved
embeddings/model/lightning_module/lightning_module.py Outdated Show resolved Hide resolved
tests/test_flair_inference.py Outdated Show resolved Hide resolved
tests/test_flair_inference.py Outdated Show resolved Hide resolved
tests/test_flair_inference.py Outdated Show resolved Hide resolved
tests/test_lightning_inference.py Outdated Show resolved Hide resolved
tests/test_lightning_inference.py Outdated Show resolved Hide resolved
tests/test_lightning_inference.py Outdated Show resolved Hide resolved
tests/test_flair_inference.py Outdated Show resolved Hide resolved
tutorials/validate_lightning_models_inference.ipynb Outdated Show resolved Hide resolved
@djaniak djaniak temporarily deployed to Test deployment April 12, 2022 15:57 Inactive
@djaniak djaniak requested review from asawczyn and ktagowski April 12, 2022 16:25
@djaniak djaniak temporarily deployed to Test deployment April 13, 2022 13:09 Inactive
@djaniak djaniak merged commit 54e4b19 into main Apr 13, 2022
@djaniak djaniak deleted the feature/trained-models-inference branch April 13, 2022 14:46
mkossakowski19 pushed a commit that referenced this pull request May 12, 2022
@djaniak @mkossakowski19
Feature/trained models inference (#226)
bf93d6a 
* feat: allow for loading lightning model from ckpt

* fix: missing arg in lightning_sequence_labeling.py

* feat: notebook with inference example for lightning

* feat: notebook with inference example for flair

* feat: implement load_from_ckpt method for LightningTask

* fix: restore inference after rebase for lightning

* feat: tests for lightning inference

* refactor: move lightning inference notebook to tutorials and refactor

* refactor: switch to herbert for testing inference

* feat: implement flair task from_checkpoint method

* refactor: lightning inference and datamodule

* tests: add flair trained model inference

* refactor: update notebooks with current code

* refactor: naming in Lightning modules

* fix: tests and notebooks after rebase

* refactor: loading model from ckpt for lightning

* fix(tests): flair inference tests

* fix(tests): isort

* fix: inference for lightning pipelines

* refactor: inference tests for flair and lightning

* misc: update tutorial notebook

* refactor: pr issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktagowski ktagowski ktagowski approved these changes

@asawczyn asawczyn asawczyn approved these changes

Assignees

@djaniak djaniak

Labels
None yet
Projects
None yet
Milestone
[Milestone 2] First version of Polish...
Development

Successfully merging this pull request may close these issues.
3 participants
@djaniak @ktagowski @asawczyn