Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove hard dependency on nvim-treesitter #71

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

soifou
Copy link
Contributor

@soifou soifou commented Jan 18, 2025

Remove hard dependency on nvim-treesitter for two reasons:

  1. vim.treesitter.get_parser has been in Neovim core for 4 years.
  2. nvim-treesitter's future focus will be on parser installation and
    query aggregation only.

Use Neovim's built-in TreeSitter API instead.

Closes #70

Remove hard dependency on `nvim-treesitter` for two reasons:

1. `vim.treesitter.get_parser` has been in Neovim core for 4 years.
2. nvim-treesitter's future focus will be on parser installation and
   query aggregation only.

Use Neovim's built-in TreeSitter API instead.

Closes CKolkey#70
@soifou
Copy link
Contributor Author

soifou commented Jan 18, 2025

I think it's safe to remove the dependency rather than deprecate it. I did several checks to correctly grab the parser from nvim-0.8 to nvim-0.12

I have not yet touched the spec or the workflow, as I see you install some parsers but don't fully grasp the intent.

@CKolkey CKolkey merged commit 030b1b4 into CKolkey:master Jan 19, 2025
1 of 2 checks passed
@CKolkey
Copy link
Owner

CKolkey commented Jan 19, 2025

Thanks!

@soifou soifou deleted the feat/vim-treesitter branch January 19, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing hard dependency of nvim-treesitter ?
2 participants