Add initialization of n_aero to icepack driver #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Add initialization of n_aero in icepack driver
apcraig
Tested in icepack on conrad with 4 compilers. All tests pass EXCEPT the pondcesm test case indicates non-bit-for-bit vs the baseline. I have compared the ice_diag files for all pondcesm cases vs the baseline, and they are bit-for-bit, but the restart file (which is what is compared in the test) is not. I suspect something is written slightly different into the restart file that does not affect answers. This seems to happen just for the pondcesm case. I don't understand why. Because the restart files are binary, it's not easy to identify the differences. But I think we can accept this since the ice_diag files are identical.
https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#7259556232cebf37f4c9b42b4ba0b866a07d196b