Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyright and version number #301

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Update copyright and version number #301

merged 1 commit into from
Feb 21, 2020

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Feb 20, 2020

PR checklist

  • Short (1 sentence) summary of your PR:
    Update copyright and version number
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran a quick suite on conrad with 4 compilers, all pass. This is probably adequate as no source code or scripts were changed. https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#243ac613d91e80b19c7328dd3b2dac4bb2768c88
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Only documentation updated was the copyright. Version was updated in preparation for next minor release.

eclare108213
eclare108213 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.
I assume there will be a similar PR for CICE, and we need to check About-Us too.
Thank you.

@apcraig
Copy link
Contributor Author

apcraig commented Feb 21, 2020

I will be creating an equivalent for CICE shortly.

@apcraig apcraig merged commit 7259556 into CICE-Consortium:master Feb 21, 2020
@apcraig apcraig mentioned this pull request Feb 21, 2020
Closed
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
@apcraig
Refactor bit-for-bit diagnostics (CICE-Consortium#300)
d417b97 
* implement bfb for mpi comm global sums, fix compile issue with cpps, remove unused cpps

* add set_nml.reprosum

* update global reductions for serial mode to leverage bfbflag in the same way as mpi mode

* update and fix bfb compare feature

* add comparelog.csh script and logbfb test

* update travis gcc, fix tdir feature with tests

* update Makefile for c compiles, update Macros files to support c compile and serial/parallel compiles better and cleaner

* modify report results script to address grep for bfbcomp cases, add first_suite.ts

* fix Macros.onyx_intel, accidently removed debug flags in earlier commit

* update travis c build

* fix script logic for more threads than tasks per node

* update scripts to address CICE-Consortium#299, poll_queue script and CICE-Consortium#301, single test bgen default use

* add QSTAT variables to fram and cesium
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclare108213 eclare108213 eclare108213 approved these changes

@duvivier duvivier Awaiting requested review from duvivier

Assignees
No one assigned
Labels
Documentation Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apcraig @eclare108213