Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zenodo json template and report_results script #278

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Oct 19, 2019

PR checklist

  • Short (1 sentence) summary of your PR:
    Update zenodo json template and report_results script
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Ran quick suite on gordon, report results seem to work fine. hash 5af4649 at https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks tested on Oct 18.
    Not sure about zenodo changes.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Zenodo json update based on feedback from zenodo folks. will test on next release.
Updated report_results to remove some of the reports and sync the icepack and CICE report_results script again.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apcraig
Copy link
Contributor Author

apcraig commented Oct 19, 2019

I have just update the json template as suggested and I also modified the serial launch for conrad, gordon, and onyx to use aprun. I ran the full test suite on gordon with all 4 compilers and everything is bit-for-bit with master. hash #3d7d5366bc9be at https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks.

@apcraig
Copy link
Contributor Author

apcraig commented Oct 20, 2019

The full gordon test results are hash #6cc6dd5a65e at https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks.

@apcraig apcraig self-assigned this Oct 21, 2019
@apcraig apcraig merged commit 6b55dce into CICE-Consortium:master Oct 22, 2019
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
* Vectorized EVP kernel

* Vectorized EVP using evp_kernel1d.F90

* Vectorized EVP kernel using evp_kernel1d.F90

* Possible OMP issues: Search for "MHRI"

* Update kernel to reflect new changes in revised EVP (revp) + bottom stress (Ktens)

* Remove unused variables

* Error correction in rEVP implementation

* Vectorized EVP kernel

* Vectorized EVP using evp_kernel1d.F90

* Vectorized EVP kernel using evp_kernel1d.F90

* Possible OMP issues: Search for "MHRI"

* Update kernel to reflect new changes in revised EVP (revp) + bottom stress (Ktens)

* Remove unused variables

* Error correction in rEVP implementation

* Added timer for 1d/2d EVP kernel

* Added timer for EVP

* Renamed to ice_dyn_evp_1d.F90

* Remove "strocnx,strocny" from stepu. Calculated in dyn_finish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants