Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates for cice bfb, fix build, remove dead cpps #256

Merged
merged 1 commit into from
Mar 16, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Mar 14, 2019

Updates needed for CICE bfb branch

Fixed a problem in the build where the cpps were not being processed properly.
Removed dead cpps and dead cice_settings.
Added integer8 kind and updated real16 kind.

Copy link
Contributor

@dabail10 dabail10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was unaware that CAM_ICE, DITTO, and BARRIERS were no longer used. I don't have them in CESM-CICE5. Thanks for doing this cleanup.

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense that these cpps are not needed for Icepack. They might still be used for CICE, but that would be a separate set of changes.

@apcraig apcraig merged commit ac6195d into CICE-Consortium:master Mar 16, 2019
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants