Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods needed for RASM #208

Merged
merged 3 commits into from
Jun 30, 2018
Merged

Mods needed for RASM #208

merged 3 commits into from
Jun 30, 2018

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented Jun 24, 2018

Modifications in Icepack needed to support RASM coupling

  • Developer(s): tcraig

  • Please suggest code Pull Request reviewers in the column at right.

  • Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N
    Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
    which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-icepack/.

  • Other Relevant Details:

Added icepack_init_orbit and icepack_query_orbit to set orbital parameters.

@apcraig apcraig self-assigned this Jun 24, 2018
Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine to me,
modulo documentation updates as usual...

@eclare108213
Copy link
Contributor

@apcraig is this ready to merge or are you still working on it? You assigned yourself, and that's fine...

@apcraig apcraig assigned eclare108213 and unassigned apcraig Jun 30, 2018
@apcraig
Copy link
Contributor Author

apcraig commented Jun 30, 2018

Documentation is updated and things look ready to merge. I change assignee to @eclare108213. I set it as me, so it wouldn't be merged until I was sure it was ready. Let me know if something else is needed.

@eclare108213 eclare108213 merged commit f747621 into CICE-Consortium:master Jun 30, 2018
lettie-roach pushed a commit to lettie-roach/Icepack that referenced this pull request Oct 18, 2022
* updating sst and sss data_type and restore nml settings

* adding default_season to the namelist

* changing radiation namelist value names

* updates to doc and zbgc namelist

* Updating testing doc

* re-order namelist to match icepack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants