Unused and Dummy variables

[dabail10]

This is a big one as I have removed all of the dummy and unused variables. I have attempted to just comment out cases that look like place holders. Note there are two answer changing bugs here. One is in icepack_atmo.F90 and icedrv_init_column.F90. These are issues #136 and #138.
Developer(s): D. Bailey
Are the code changes bit for bit, different at roundoff level, or more substantial? The changes are more than roundoff, but should not change the climate.
Is the documentation being updated with this PR? (Y/N) N
If not, does the documentation need to be updated separately? (Y/N) N
"Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://cice-consortium.github.io/Icepack/
Please suggest code reviewers in the column at right.
Other Relevant Details:

[eclare108213]

I think the SVN:$Id: lines should be removed completely, since the dates, versions numbers etc will no longer change with new code modifications. This doesn’t have to be done as part of this PR.

Another note: Preprocessing flag changes from CCSMCOUPLED to CESMCOUPLED will also need to be done in CICE.

in subroutine flush_pond (icepack_therm_mushy), I think you should leave both of the 'sadded' lines in the code, but commented out, for later reference. We might need to look back at what's done and that information could be helpful.

In subroutine ice_step (icedrv_RunMod), please make a line for debugging and comment it out like this (this is useful for debugging, using other commented-out lines below):
! use icedrv_diagnostics, only: icedrv_diagnostics_debug

[dabail10]

I added your suggested changes and went ahead and got rid of the SVN lines. I agree that CICE needs CCSMCOUPLED changes to CESMCOUPLED as well.

Dave

[dabail10]

Don't approve yet, I have more to come.

[apcraig]

Thanks Dave, I'm sure this was a bunch of work.

[apcraig]

Dave, is this ready to merge once we get reviews done? Or do you have more?