Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hycom forcing check and gbox128 tests batch time limit #315

Merged
merged 1 commit into from
May 30, 2019

Conversation

apcraig
Copy link
Contributor

@apcraig apcraig commented May 23, 2019

Update hycom forcing check, #273
Update some gbox128 tests to add short to add some extra batch queue time. Some of these tests were intermittently timing out on conrad due to time limits.

  • Developer(s): mhrib, tcraig

  • Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit

  • Does this PR create or have dependencies on Icepack or any other models? N

  • Is the documentation being updated with this PR? (Y/N) N
    If not, does the documentation need to be updated separately at a later time? (Y/N) N

  • Other Relevant Details:

Tested with 4 compilers on conrad, all tests passed. #37b799c3e2, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks

Retested the failed test with updated short settings and all those tests passed (not shown).

Copy link
Contributor

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. It would be good if @mhrib can take a look also and test the ice_forcing change.

@apcraig apcraig merged commit 48305b6 into CICE-Consortium:master May 30, 2019
@apcraig apcraig deleted the hycomforc branch August 17, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants