Documentation #28
Merged
Documentation #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclare108213
approved these changes
Sep 21, 2017
|
It looks to me like all the changes were made properly. Now that this is in place, I have updated the wiki links to point to the appropriate documentation shown in the README.md file. |
JFLemieux73
pushed a commit
to JFLemieux73/CICE
that referenced
this pull request
Nov 19, 2021
* ice_flux: add stress arrays at CD-grid locations (T,U)
* ice_dyn_shared: initialize CD-grid stress arrays
* infrastructure: add CD-grid stress arrays to restarts
* ice_dyn_shared: generalize 'principal_stress' arguments names
In a subsequent commit we will call 'principal_stress' with the CD-grid
stress arrays 'stress{p,m,12}T' to compute the principal stresses at the
tracer point when using the CD grid.
In that light, remove the '_1' suffix from the stress arguments since
they won't always be located at the NE corner anymore.
* ice_history: compute 'sig[12P]' at T-point for CD-grid
For the CD-grid, compute the principal stresses and the ice pressure at
the T point by passing the appropriate arrays to 'principal_stress'.
These three history variables are computed using the NE-corner values on
the B-grid, but this is not reflected in the description of the fields
in the history output.
Add the location at which the stresses are computed to the comment
argument in the call to 'define_hist_field', for both the B and CD grid.
* ice_dyn_evp: pass 'stress{p,m,12}[TU]' to dyn_prep2
For the CD-grid, the 'stress{p,m,12}_[1-4]' arrays are not used. Pass
the CD-grid location stress arrays 'stress{p,m,12}[TU]' to 'dyn_prep2',
which zero-initializes them anywhere icetmask is zero.
Also, add a TODO in the `if (grid_type) == 'tripole'` block, since it is
not yet clear how the halo updates should be done for the new stress
arrays on the tripole grid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to CICE documentation files (*.rst) to include section on Quikstart and Testing the model. Removed README.test, README_v6, and links to the Quikstart Google Doc (all of which were put into the sphinx documentation instead), modified README.md to link to the sphinx documentation. The wiki will still need to be edited not as part of this PR.
Developer(s): Alice DuVivier
Updated documentation (Y/N): Y
Results (bit for bit, roundoff, climate changing): Bit for bit
Code review:
Other Relevant Details: