-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allowing user to set axis limits when plotting #224
Conversation
@WPringle check out |
I'll wait for #221 to get merged and then rebase this before testing. Although probably should expand testing to all combinations of plotting as there some untested configurations. |
yeah that's funny how it prompts you to agree that it "looks right?". I wonder if you could count pixels or something silly like that. |
The only way I think to test plotting off the top of my head would be to have a bunch of reference images and compute the spatial correlation between the images. However, this is overkill imo. |
I think this fine to go for now. The testing of the plotting just runs through some common configurations to ensure some configuration doesn't break as we add future codes (labels, ticks, titles, colorbars, log options, etc.). |
- Changing the test metric for TestEleSizes.m so that it works without the statistics toolbox (prctile)
Made some small corrections to the other tests as shown in the commit. For the plotting test some of those options don't really work together (e..g, 'trinotri') but maybe it's good to know it doesn't error? |
Yea, basically the idea is to test the API and make sure there's no failure. Perhaps in the future combinations of options that don't make sense would result in some feedback for the user. |
axis_limits
which over rides the default mesh extents.