Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing user to set axis limits when plotting #224

Merged
merged 8 commits into from
May 23, 2021
Merged

Conversation

krober10nd
Copy link
Collaborator

  • User can set the axis limits with a kwarg axis_limits which over rides the default mesh extents.
plot(m,'type','tri','proj','lamb','axis_limits',[164, 178; -48 -40]);

@krober10nd
Copy link
Collaborator Author

@WPringle check out test_plotting didn't have much time to work on this today but we should have a routine that goes through the majority of combinations for plotting and visualize them to make sure it makes sense. Can't really automatically do this...

@krober10nd
Copy link
Collaborator Author

I'll wait for #221 to get merged and then rebase this before testing. Although probably should expand testing to all combinations of plotting as there some untested configurations.

@WPringle
Copy link
Collaborator

@WPringle check out test_plotting didn't have much time to work on this today but we should have a routine that goes through the majority of combinations for plotting and visualize them to make sure it makes sense. Can't really automatically do this...

yeah that's funny how it prompts you to agree that it "looks right?". I wonder if you could count pixels or something silly like that.

@krober10nd
Copy link
Collaborator Author

The only way I think to test plotting off the top of my head would be to have a bunch of reference images and compute the spatial correlation between the images. However, this is overkill imo.

@krober10nd
Copy link
Collaborator Author

I think this fine to go for now. The testing of the plotting just runs through some common configurations to ensure some configuration doesn't break as we add future codes (labels, ticks, titles, colorbars, log options, etc.).

- Changing the test metric for TestEleSizes.m so that it works without the statistics toolbox (prctile)
@WPringle
Copy link
Collaborator

Made some small corrections to the other tests as shown in the commit.

For the plotting test some of those options don't really work together (e..g, 'trinotri') but maybe it's good to know it doesn't error?

@krober10nd
Copy link
Collaborator Author

Yea, basically the idea is to test the API and make sure there's no failure. Perhaps in the future combinations of options that don't make sense would result in some feedback for the user.

@krober10nd krober10nd merged commit d349eb3 into Projection May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants