Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-action - doxygen now reports warning as errors #28

Merged
merged 2 commits into from
Oct 9, 2024
Merged

github-action - doxygen now reports warning as errors #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8c6bdd
telemetry - fix undocumented Holder constructors
SiskaPavel Oct 9, 2024
a5880ca
github-action - doxygen now reports warning as errors
SiskaPavel Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
dnf config-manager --set-enabled ol9_codeready_builder
dnf install -y doxygen
- name: make doxygen
run: make doxygen
run: make doxygen CMAKE_ARGS="-DDOXYGEN_WARN_AS_ERROR=YES"
- name: upload Doxygen artifact
uses: actions/upload-artifact@v4
with:
Expand Down
12 changes: 11 additions & 1 deletion include/telemetry/holder.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,17 @@ class Holder {

Holder(const Holder& other) = delete;
Holder& operator=(const Holder& other) = delete;
Holder(Holder&& other) = default;
/**
* @brief Move constructor
* @param other Other holder
*/
Holder(Holder&& other) = delete;

/**
* @brief Move assignment
* @param other Other holder
* @return Reference to this holder
*/
Holder& operator=(Holder&& other) = default;

/**
Expand Down