-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cprnc does not FAIL if fields are missing #144
Comments
I think that adding a variable and deleting a variable should both be considered FAIL. Adding a field can also be a mistake, albeit one that's usually less bad than accidentally removing a field. Plus, if only deleting a variable was considered to FAIL, we would lose symmetry. It would be counter-intuitive if tag A failed baseline tests against tag B, but tag B passed baseline tests against tag A. Or to put it differently, baseline comparison should define an equivalence relation between tags. |
…archive Fix for initializing env_archive.xml
Feeling is that this should be reported, but maybe labeled differently from a FAIL? |
Decision in CSEG meeting: We'll have cprnc report a warning if fields have been either added or removed. |
I have addressed the cprnc side of this issue in #442 After that change comes to master, we'll still need to do the following:
Adding @fischer-ncar to the cc list |
I think we should do the following:
No need to clone the entire CIME repo just to access |
This issue was moved to ESMCI#870 |
While cprnc notes if fields cannot be compared, it does not FAIL a comparison if a field (NetCDF variable) goes missing. I can see allowing a new field but if we delete a field, should that count as an answer change? If not cprnc itself, then should a comparison test FAIL in this case?
The text was updated successfully, but these errors were encountered: