-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update end to end test #353
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 29.26% 30.47% +1.21%
==========================================
Files 25 26 +1
Lines 1910 1939 +29
==========================================
+ Hits 559 591 +32
+ Misses 1351 1348 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6a593ae
to
98b24c3
Compare
5c47273
to
8f53d08
Compare
…update-end-to-end-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good. Thanks, @sbidari! Just a few questions before I review further.
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
@dylanhmorris I have made the changes we discussed yesterday. This passes the pipeline run check but fails on a test for |
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
* Adjust to fix test * Update pyrenew_hew/pyrenew_wastewater_data.py * Hack fix * pre-commit --------- Co-authored-by: sbidari <zib2@cdc.gov>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question and one suggestion. Thanks, @sbidari!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM provided tests pass, thanks @sbidari!. In the future we should more fully separate the subpopulation specification from the wastewater data specification (so you can do multi-subpop models without observed wastewater). This should also help with the pop-fraction stuff. But it's out of scope for now.
Key changes:
Adds
generate_fake_nwss_data
function ingenerate_test_data.R
Modifies
end_to_end_test.sh
to fitPyrenew-HEW
model for COVID-19Adds
PyrenewWastewaterData
class to handle wastewater data.Modifies
build_model_from_dir
and related functions to incorporate wastewater data.Adds priors for wastewater-related parameters in
prod_priors.py
andbuild_pyrenew_model.py
Modifies
forecast_state.py
to handle wastewater data:-scan for NWSS data conditional on
fit_wastewater
flag-raise errors if wastewater data is not available for the requested report date.
Moved calculation of
pop_fraction
fromPyrenewHEWData
toprep_data.py
(required arg forLatentInfectionProcess
)