Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for to_epiweekly_quantile_table.R #255

Merged
merged 18 commits into from
Dec 18, 2024

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Dec 17, 2024

add tests for to_epiweekly_quantile_table.R and to_epiweekly_quantile.R functions

@sbidari sbidari linked an issue Dec 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.08%. Comparing base (c7f6c1e) to head (030edd6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##            main     #255      +/-   ##
=========================================
+ Coverage   8.17%   17.08%   +8.91%     
=========================================
  Files         21       21              
  Lines       1346     1346              
=========================================
+ Hits         110      230     +120     
+ Misses      1236     1116     -120     
Flag Coverage Δ
hewr 48.79% <ø> (+26.25%) ⬆️
pipelines 0.00% <ø> (ø)
pyrenew_hew 1.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review December 17, 2024 23:12
Copy link
Contributor

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the use of withr resolved the windows issue. One suggestion @sbidari

@damonbayer damonbayer self-requested a review December 18, 2024 20:18
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbidari!

@damonbayer damonbayer enabled auto-merge (squash) December 18, 2024 20:19
@damonbayer damonbayer merged commit f275238 into main Dec 18, 2024
13 checks passed
@damonbayer damonbayer deleted the 198-test-for-to_epiweekly_quantile_table branch December 18, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test for to_epiweekly_quantile_table
3 participants