Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to end test is broken in CI #297

Closed
dylanhmorris opened this issue Jan 15, 2025 · 4 comments
Closed

End to end test is broken in CI #297

dylanhmorris opened this issue Jan 15, 2025 · 4 comments

Comments

@dylanhmorris
Copy link
Contributor

dylanhmorris commented Jan 15, 2025

This run of the end the merge of the latest change to main succeeded: https://github.com/CDCgov/pyrenew-hew/actions/runs/12675517508/job/35326715753

This re-run of it (with cleared cache) fails: https://github.com/CDCgov/pyrenew-hew/actions/runs/12675517508/job/35653451264

Hypothesizing that the problem has something to do with the change of ubuntu-latest from the 22.04 image (used in the first run) and the 24.04 image (used in the re-run).

Test runs locally for me without error.

@dylanhmorris
Copy link
Contributor Author

@sbidari for awareness.

@dylanhmorris
Copy link
Contributor Author

dylanhmorris commented Jan 15, 2025

Test runs fine in CI on ubuntu-22.04 and macos-latest. I think to unblock changes we should switch to those runners and explore making it work in ubuntu-latest as a separate, lower-priority issue (especially as it is possible that the problem might be upstream, e.g. with how quarto is set up when R is not preinstalled on a runner). @damonbayer @sbidari

@sbidari
Copy link
Collaborator

sbidari commented Jan 15, 2025

Sounds good to me!

@dylanhmorris
Copy link
Contributor Author

Closed by #295. Will open a new issue for investigating compatibility with ubuntu-24.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants