Bump org.yaml:snakeyaml from 1.33 to 2.0 in /prime-router #9426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
94d883f to
dbe7594
Compare
dbe7594 to
4ceabca
Compare
oslynn
previously approved these changes
May 9, 2023
4ceabca to
172a28d
Compare
|
@dependabot rebase |
Bumps [org.yaml:snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.33 to 2.0. - [Commits](https://bitbucket.org/snakeyaml/snakeyaml/branches/compare/snakeyaml-2.0..snakeyaml-1.33) --- updated-dependencies: - dependency-name: org.yaml:snakeyaml dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
172a28d to
d82f1b9
Compare
snesm
reviewed
May 15, 2023
| // Pin snakeyaml since it is getting included regardless of exclude attempts | ||
| implementation("org.yaml:snakeyaml:1.33") | ||
| implementation("com.github.javafaker:javafaker:1.0.2") { | ||
| exclude(group = "org.yaml", module = "snakeyaml") |
There was a problem hiding this comment.
javafaker uses: android
which does not exist for snakeyaml:2.0
snesm
reviewed
May 15, 2023
| @@ -105,7 +105,7 @@ defaultTasks("package") | |||
|
|
|||
| val ktorVersion = "2.3.0" | |||
| val kotlinVersion = "1.8.20" | |||
| val jacksonVersion = "2.14.1" | |||
| val jacksonVersion = "2.15.0" | |||
There was a problem hiding this comment.
first version to support snakeyaml:2.0
snesm
reviewed
May 15, 2023
| @@ -127,7 +126,7 @@ class EmailSenderFunction { | |||
| private fun parseBody(requestBody: String, logger: Logger): TosAgreementForm? { | |||
| return try { | |||
| jacksonObjectMapper().readValue<TosAgreementForm>(requestBody, TosAgreementForm::class.java) | |||
| } catch (ex: MissingKotlinParameterException) { | |||
| } catch (ex: Exception) { | |||
There was a problem hiding this comment.
'MissingKotlinParameterException' is deprecated. It will be removed in jackson-module-kotlin 2.16. See #617 for details.
There was a problem hiding this comment.
That ticket and the kdoc for MismatchedInputException makes it seem like we can use the more specific exception name.
Use a more specific exception
luis-pabon-tf
approved these changes
May 31, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps org.yaml:snakeyaml from 1.33 to 2.0.
Commits
c98ffbaissue 561: add negative test casee2ca740Use Maven wrapper on github49d91a1Fix target for github19e331dDisable toolchain for github42c7812Cobertura plugin does not work03c82b5Rename GlobalTagRejectionTest to be run by Maven6e8cd89Remove coberturad9b0f48Improve Javadoc519791aRun install and site goals under docker82f33d2Merge branch 'master' into add-module-infoDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)