Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support section with contact and faq pages #5649

Closed
wants to merge 10 commits into from
Closed

Conversation

drew-usds
Copy link
Contributor

@drew-usds drew-usds commented Jun 2, 2022

This PR ...

Adds a new top-level nav area for /support

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. Include steps to test these changes

Changes

  • Adds new top-level nav element for /support
  • Adds new dropdown menu for /support pages
  • Adds /support/faq page
  • Adds /contact page
  • Fixes typo in /getting-started

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

To Be Done

Create GitHub issues to track the work remaining, if any

  • Pages are bare-bones for now, will become future customer support/help center pages.

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

Pull reviewers stats

Stats for the last 30 days:

User Total reviews Time to review Total comments
jeremy-page 29 1h 12m 3
carlosfelix2 14 14h 15m 45
kevinhaube 11 1h 21m 8
MauriceReeves-usds 10 7h 40m 0
clediggins-usds 9 2h 13m 12
TomNUSDS 6 25m 20
brick-green 6 36m 0
bgantick 5 1h 22m 2
oslynn 5 13h 24m 2
jorg3lopez 5 2h 30m 0
sethdarragile6 4 1h 50m 4
mreifman 3 32m 1
ahay-agile6 3 3m 1
doug-s-nava 2 2h 32m 10
JosiahSiegel 1 3m 0
RickHawesUSDS 1 6m 2
jimduff-usds 1 12h 26m 0

@drew-usds drew-usds self-assigned this Jun 2, 2022
@drew-usds drew-usds changed the title Add "support" section with contact and faq pages Add support section with contact and faq pages Jun 2, 2022
@hannasage hannasage self-requested a review June 2, 2022 15:46
import { useEffect, useState } from "react";
import { NavLink } from "react-router-dom";

const SupportDropdown = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna reach out about not duplicating the dropdowns and instead using a new component from #5601 to create this.

@drew-usds drew-usds added the experience Team label to flag issues owned by the Experience Team label Jun 2, 2022
@hannasage
Copy link
Contributor

Drew you should be good to pull in master and use DropdownNav and makeNonStaticOption to create this nav item. Reach out if you run into issues, but the DropdownNav file should have examples!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

let itemsMenu = [
<GettingStartedDropdown />,
<HowItWorksDropdown />,
<SupportDropdown />,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not shipping with content, let's add this dynamically with CheckFeatureFlag("support") like we do down on line 42 with Built For You

@drew-usds
Copy link
Contributor Author

Forgot this was sitting here as a PR! Closing this, we're going to publish it as part of revamped MD pages this sprint or the next.

@drew-usds drew-usds closed this Jun 21, 2022
@jeremy-page jeremy-page deleted the dg/contact-faq branch May 15, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experience Team label to flag issues owned by the Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants