Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove storybook-addon-remix-react-router #17181

Closed
3 tasks done
jpandersen87 opened this issue Jan 27, 2025 · 0 comments · Fixed by #17182
Closed
3 tasks done

Remove storybook-addon-remix-react-router #17181

jpandersen87 opened this issue Jan 27, 2025 · 0 comments · Fixed by #17182
Assignees
@jpandersen87
Labels
experience Team label to flag issues owned by the Experience Team tech-debt Anything that is purely a technical issue and does not affect functionality

Comments

@jpandersen87
Copy link
Collaborator

jpandersen87 commented Jan 27, 2025 •
edited
Loading

The latest version of this addon no longer supports the remix-router version we are pinned to and was only being called on for one story (but not actively using it). It should be removed until actively needed (using a supported version).

Acceptance Criteria

  • storybook-addon-remix-react-router dependency removed
  • usages of addon removed
  • no storybook errors occur related to this
@jpandersen87 jpandersen87 added experience Team label to flag issues owned by the Experience Team tech-debt Anything that is purely a technical issue and does not affect functionality labels Jan 27, 2025
@jpandersen87 jpandersen87 self-assigned this Jan 27, 2025
jpandersen87 added a commit that referenced this issue Jan 27, 2025
@jpandersen87
Remove storybook-addon-remix-react-router
becadec 
Fixes #17181
@jpandersen87 jpandersen87 mentioned this issue Jan 27, 2025
Merged
jpandersen87 added a commit that referenced this issue Feb 6, 2025
@jpandersen87
Remove storybook-addon-remix-react-router (#17182)
067f348 
Fixes #17181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpandersen87 jpandersen87

Labels
experience Team label to flag issues owned by the Experience Team tech-debt Anything that is purely a technical issue and does not affect functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove storybook-addon-remix-react-router CDCgov/prime-reportstream
1 participant
@jpandersen87