Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We no longer need the openshift client because #37

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

naved001
Copy link
Collaborator

@naved001 naved001 commented Feb 8, 2024

  1. For gathering metrics we make a request call and for that we can set the openshift token as an environment variable.
  2. We no longer gather namespace annotations, instead we are getting allocation attributes from coldfront.

1. For gathering metrics we make a request call and for that we can set the
openshift token an an environment variable.
2. We no longer gather namespace annotations, instead we are getting allocation
attributes from coldfront.
@naved001 naved001 force-pushed the remove-openshift-dependency branch from dec5827 to 30fe0bf Compare February 8, 2024 18:59
@naved001 naved001 requested a review from knikolla February 8, 2024 19:00
@naved001 naved001 changed the title We no longer need the openshift client in the code because We no longer need the openshift client because Feb 8, 2024
Copy link
Contributor

@knikolla knikolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. When this runs in a container you can just fetch the mounter service account token.

@naved001 naved001 merged commit b3127bc into CCI-MOC:main Feb 8, 2024
1 check passed
@naved001 naved001 deleted the remove-openshift-dependency branch October 29, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants