Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create template repository with license and contribution agreement #1

Merged
merged 4 commits into from
Sep 7, 2022
Merged

Create template repository with license and contribution agreement #1

merged 4 commits into from
Sep 7, 2022

Conversation

larsks
Copy link
Member

@larsks larsks commented Aug 5, 2022

Create a template repository both to serve as the model for creating new repositories and to serve as the canonical location for the LICENSE and CONTRIBUTING.md files.

larsks added 4 commits August 5, 2022 18:47
@larsks
Create MOC template repository
78f7f33 
Create MOC template repository with Apache 2.0 license, contribution
agreement, etc.

Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
@larsks
Add CONTRIBUTING.md
8e114a2 
This is based off [1].

[1]: https://github.com/grafana/helm-charts/blob/main/CONTRIBUTING.md

Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
Closes: CCI-MOC/ops-issues#659
@larsks
Add README template
c389402 
Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
@larsks
Add pre-commit workflow
f3f3636 
Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
@larsks larsks mentioned this pull request Aug 5, 2022
Open
knikolla
knikolla approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@knikolla knikolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Good work Lars.

@larsks larsks requested review from joachimweyl and msdisme August 26, 2022 14:03
joachimweyl
joachimweyl reviewed Aug 26, 2022
View reviewed changes
Copy link

@joachimweyl joachimweyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the technical accuracy but there are no typos that I see and the pre-commit hook rules look correct. The readme and contributing documents look good.
Is there a way to add a hook or some other feature that refuses pulls that do not include "Signed-off-by:"? Is that what the --signoff does?

@larsks
Copy link
Member Author

larsks commented Aug 26, 2022

I can't speak to the technical accuracy but there are no typos that I see and the pre-commit hook rules look correct.

The open question, particularly for you and @msdisme , is whether or not this document accurately expresses our policy as you understand it.

Is there a way to add a hook or some other feature that refuses pulls that do not include "Signed-off-by:"? Is that what the --signoff does?

There is a separate issue for creating that sort of automation (CCI-MOC/ops-issues#657).

joachimweyl
joachimweyl approved these changes Aug 26, 2022
View reviewed changes
Copy link

@joachimweyl joachimweyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.MD accurately expresses our policy to my understanding.

@joachimweyl
Copy link

@msdisme as you have more experience with licensing than I do, this PR would benefit from your review.

@larsks larsks merged commit 518104b into CCI-MOC:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachimweyl joachimweyl joachimweyl approved these changes

@knikolla knikolla knikolla approved these changes

@msdisme msdisme Awaiting requested review from msdisme

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@larsks @joachimweyl @knikolla