Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #64/update linting tools #65

Conversation

lpardey
Copy link
Collaborator

@lpardey lpardey commented Jan 9, 2024

This is meant to add ruff as the main linter and code formatter.

closes #64

Copy link
Contributor

@ggutierrez-sunbright ggutierrez-sunbright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job

@ggutierrez-sunbright ggutierrez-sunbright merged commit 4584dc1 into CBDD:main Jan 9, 2024
10 checks passed
lpardey added a commit to SunBright-Technologies/rDock that referenced this pull request Jan 23, 2024
* update pyproject.toml config to work with ruff

* update devcontainer.json to work with ruff

* add ruff instead of black flake8, isort

* add exclude and ignore rules to ruff on project.toml

* remove flake8

* migrate mypy rules to project.toml

* update github actions workflow for rdock-utils
  - add ruff
  - remove flake, black, isort
  - add pytest
lpardey added a commit to SunBright-Technologies/rDock that referenced this pull request Jan 23, 2024
* update pyproject.toml config to work with ruff

* update devcontainer.json to work with ruff

* add ruff instead of black flake8, isort

* add exclude and ignore rules to ruff on project.toml

* remove flake8

* migrate mypy rules to project.toml

* update github actions workflow for rdock-utils
  - add ruff
  - remove flake, black, isort
  - add pytest
lpardey added a commit to SunBright-Technologies/rDock that referenced this pull request Jan 23, 2024
* update pyproject.toml config to work with ruff

* update devcontainer.json to work with ruff

* add ruff instead of black flake8, isort

* add exclude and ignore rules to ruff on project.toml

* remove flake8

* migrate mypy rules to project.toml

* update github actions workflow for rdock-utils
  - add ruff
  - remove flake, black, isort
  - add pytest
ggutierrez-sunbright pushed a commit that referenced this pull request Jan 27, 2024
* update pyproject.toml config to work with ruff

* update devcontainer.json to work with ruff

* add ruff instead of black flake8, isort

* add exclude and ignore rules to ruff on project.toml

* remove flake8

* migrate mypy rules to project.toml

* update github actions workflow for rdock-utils
  - add ruff
  - remove flake, black, isort
  - add pytest
@lpardey lpardey deleted the issue-#64/update-linting-tools branch February 2, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rdock-utils] update linting tools
2 participants