Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality 137/improve serialization deserialization #142

Merged
merged 21 commits into from
Dec 16, 2024
Merged

Quality 137/improve serialization deserialization #142

merged 21 commits into from
Dec 16, 2024

Conversation

ggutierrez-sunbright
Copy link
Contributor

Added:

  • auxiliary functions for binary read and write
  • auxiliary function to check for class name during deserialization
  • test to verify the new .as files generated are identical to the original ones (for retro-compatibility)
  • some additional code quality improvements

closes #137

@ggutierrez-sunbright
general improvements to file sink and source
f049ab6
@ggutierrez-sunbright
Merge branch 'main' into quality-137/improve-serialization-deserializ…
01c7543 
…ation
@ggutierrez-sunbright
fix exceptions, improve file sink constructors
4b67c33
@ggutierrez-sunbright
add auxiliary functions for binary read/write
d288a08
@ggutierrez-sunbright
replace {Read/Write}WithThrow in coord and cavity
7fd821e
@ggutierrez-sunbright
replace Read/WriteWithThrow with bin_read/write in rbcalcgrid
c271f17
@ggutierrez-sunbright
replace Read/WriteWithThrow with bin_read/write in rbconvgrid
31b5ace
@ggutierrez-sunbright
replace Read/WriteWithThrow with bin_read/write in base grid
baffd90
@ggutierrez-sunbright
update rbconvgrid with the specialized bin_read/write for strings
1f7198f
@ggutierrez-sunbright
replace Read/WriteWithThrow with bin_read/write in fft grid
c98f08b
@ggutierrez-sunbright
replace Read/WriteWithThrow with bin_read/write in pmf grid
3e7bb10
@ggutierrez-sunbright
add modifications to bin_read/write string specialization for retroco…
a3a9124 
…mpatibility
@ggutierrez-sunbright
replace Read/WriteWithThrow with bin_read/write in real grid
9ad9af7
@ggutierrez-sunbright
replace Read/WriteWithThrow with bin_read/write in vdw grid
27c73b0
@ggutierrez-sunbright
replace Read/WriteWithThrow with bin_read/write in docking site
4c2aa76
@ggutierrez-sunbright
remove original read/write with throw
e4421a6
@ggutierrez-sunbright
add diff test for cavity files
0dc07d8
@ggutierrez-sunbright
homogenize string serialization behavior with old code
b35fd59
@ggutierrez-sunbright
refactor out title validation
375a548
@ggutierrez-sunbright ggutierrez-sunbright self-assigned this Dec 15, 2024
@ggutierrez-sunbright ggutierrez-sunbright added upgrade a design modification, refactor, or component replacement quality labels Dec 15, 2024
@ggutierrez-sunbright ggutierrez-sunbright merged commit a570aa9 into main Dec 16, 2024
9 checks passed
@ggutierrez-sunbright ggutierrez-sunbright deleted the quality-137/improve-serialization-deserialization branch December 16, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ggutierrez-sunbright ggutierrez-sunbright

Labels
quality upgrade a design modification, refactor, or component replacement
Projects
rDock general development board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve binary read/write for code readability
1 participant
@ggutierrez-sunbright