FIX: cba_fnc_deleteEntity where group must be local to the machine executing deleteGroup command #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://community.bistudio.com/wiki/deleteGroup * check if group is local * if not delete it where the group is local if we know it * if not send the deletegroup to the server where groupOwner can be excecuted
|
Just curious. Did you actually use that function and encountered this particular problem? |
|
First, I wrote a similar function (btc_fnc_delete) and notice this issue so I wrote this btc_fnc_deletegroup. Now, I want to use more CBA function and saw that, so I send the fix. |
|
I see. Script looks good to me. |
commy2
approved these changes
Apr 28, 2018
Vdauphin
added a commit
to Vdauphin/HeartsAndMinds
that referenced
this pull request
Apr 29, 2018
need cba 3.7 CBATeam/CBA_A3#916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I don't know if this function is supposed to be executed only locally but here is the fix in case group is not local to the machine trying to delete the group, or at least a solution.
When merged this pull request will:
cba_fnc_deleteEntitywhere the group must be local to the machine executing thedeleteGroup.deletegroupto the server wheregroupOwnercan beknow