Create vectorRotate3D.sqf #898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File for rotating one vector about a second vector as a rotation axis by a set angle measure.
dedmen
reviewed
Mar 6, 2018
| * | ||
| * [weaponDir player, [0,0,1], 25] call CBA_fnc_vectorRotate3D | ||
| * | ||
| * Public: No |
There was a problem hiding this comment.
Shouldn't this be public though?
There was a problem hiding this comment.
Not part of CBA's header anyways.
dedmen
reviewed
Mar 6, 2018
| params ["vector", "_rotationAxis", "_theta"]; | ||
|
|
||
| private _normalVector = vectorNormalized _rotationAxis; | ||
| private = _s_theta = sin(_theta); |
dedmen
reviewed
Mar 6, 2018
| @@ -0,0 +1,34 @@ | |||
| /* | |||
There was a problem hiding this comment.
Header style doesn't match rest of CBA
https://github.com/CBATeam/CBA_A3/blob/master/addons/vectors/fnc_vectRotate2D.sqf
There was a problem hiding this comment.
A better header with examples and such:
https://github.com/CBATeam/CBA_A3/blob/master/addons/settings/fnc_init.sqf
|
|
|
@commy2 |
jonpas
requested changes
Mar 6, 2018
addons/vectors/fnc_vectRotate3D.sqf
Outdated
| */ | ||
| /* ---------------------------------------------------------------------------- | ||
| Function: CBA_fnc_vectRotate3D | ||
| Description: |
There was a problem hiding this comment.
Missing newline above. Same for Returns and Author below. Might want to add an example as shown here as well:
https://github.com/CBATeam/CBA_A3/blob/master/addons/settings/fnc_init.sqf
|
|
|
👍 |
|
Needs testing. |
execVM "\x\cba\addons\vectors\test_vectors.sqf" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Add a file for rotating one vector about a second vector as a rotation axis by a set angle measure.