Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing waypointGarrison CfgFunctions entry #851

Closed
wants to merge 1 commit into from

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Dec 26, 2017

CBA_fnc_waypointGarrison was missing in cfgFunctions.

https://forums.bistudio.com/forums/topic/168277-cba-community-base-addons-arma-3/?page=46&tab=comments#comment-3258805

I don't see a reason to hide it from normal use as a function and have it be waypoint exclusive.

@commy2
Copy link
Contributor

commy2 commented Dec 26, 2017

Don't like the idea. Why not use:

_group addWaypoint [_position, 0] setWaypointScript "\x\cba\addons\ai\fnc_waypointGarrison.sqf []";

or:

[_group, _position] execVM "\x\cba\addons\ai\fnc_waypointGarrison.sqf";

This could be added to the function header though.

@dedmen
Copy link
Contributor Author

dedmen commented Dec 26, 2017

Ask the guy on BIF asking why it doesn't work. I don't know his intentions but I also don't see why it would hurt to have it accessible.

@commy2
Copy link
Contributor

commy2 commented Dec 26, 2017

Guess I'll have to sign up with a new account there then.

@commy2
Copy link
Contributor

commy2 commented Dec 26, 2017

I also don't see why it would hurt to have it accessible.

It's not meant to be a function. It wasn't designed as one. And therefore it will have flaws when used in that environment. That's very general, but it also shows in practice in this function. It isn't actually one, because it requires suspension (waitUntil). It's named "fnc_" for consistency with the BI stuff.

@kymckay
Copy link
Contributor

kymckay commented Dec 26, 2017

Shouldn't the garrison function just be making use of the taskDefend function anyway?

@commy2
Copy link
Contributor

commy2 commented Dec 26, 2017

It can't. The taskDefend is an actual function that does not need to be spawned. This one is a script that has to return true suspended once all troops reached their destinations, so that the next waypoint could be started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants