Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature branch from github-actions.yml #1329

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Remove feature branch from github-actions.yml #1329

merged 1 commit into from
Feb 17, 2025

Conversation

yucongkoo
Copy link
Contributor

@yucongkoo yucongkoo commented Feb 17, 2025 •
edited
Loading

Summary:

Fixes #1323

Changes Made:

  • Remove feature branch from github-actions.yml

Proposed Commit Message:

Remove feature branch from github-actions.yml

This feature branch was used to create the 
bug-trimming phase and it required to run
the tests when we merge into it

NorbertLoh
NorbertLoh requested changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@NorbertLoh NorbertLoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Perhaps you can elaborate more on the commit message such that others would know the reason for adding the branch to the workflow.

@yucongkoo
Copy link
Contributor Author

@NorbertLoh
I have updated the proposed commit message!

NorbertLoh
NorbertLoh approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@NorbertLoh NorbertLoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yucongkoo yucongkoo merged commit 93cd8f6 into CATcher-org:feature-bug-trimming Feb 17, 2025
@yucongkoo yucongkoo deleted the 1323-remove-setup-builds-and-test-workflow-from-feature-branch branch February 17, 2025 05:18
@yucongkoo yucongkoo self-assigned this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NorbertLoh NorbertLoh NorbertLoh approved these changes

Assignees

@yucongkoo yucongkoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yucongkoo @NorbertLoh