-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strikethrough to deleted tables #1325
Add strikethrough to deleted tables #1325
Conversation
Add strikethrough to all text contents in deleted tables. Note that we only target the non-header rows with the CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean solution 👍 . Perhaps the note in git commit message can be in a new line as writing it in one line exceeds the hard limit of 72 characters for the subject line. More information for the git commit message guidelines can be found here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR that makes a clear distinction between deleted and non-deleted bugs.
Great use of the cascading property of css. Good job! 😄
@HollaG I agree with this comment about the commit message and to add on I believe it would also be appropriate to include the reasoning for the change in a similar format as the resource linked. |
Added a red border and removed the drop shadow from the tables
I've updated to code to include a red border as well. This is up for discussion - how do we code for accessibility, or do we not need to, as there is no border in the other tables so there is still a visual difference? |
@HollaG the red border makes it more eye-catching, the opposite of what we want to achieve? |
Noted @damithc , I'll remove them |
@damithc , on further thought, it might look a little weird with the table not having any borders. Would this border color be OK? Same color as the row dividers. |
While removing the drop shadow is worth a try, I think best to put it back. Not having it hurts the high-level consistency of the page. |
Agreed. @HollaG anything more to suggest or are you happy with the current implementation as well? |
I will put back the drop shadow. I don't think there are any further changes to be made. |
5cd955d
into
CATcher-org:feature-bug-trimming
Add strikethrough to all text contents in
deleted tables. Note that we only target the
non-header rows with the CSS.
Summary:
Fixes part of #1324
Changes Made:
Add CSS style
text-decoration: line-through
to tables which require a strikethroughProposed Commit Message: