Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option --edsfile #130

Closed
wants to merge 1 commit into from
Closed

New option --edsfile #130

wants to merge 1 commit into from

Conversation

modbw
Copy link

@modbw modbw commented Aug 6, 2024

When option --edsfile is given and a xdd file was loaded a eds file is saved with the given name. This allows to have xdd as single source of truth in VCS repo.

When option --edsfile is given and a xdd file was loaded a eds file is saved with the given name. This allows to have xdd as single source of truth in VCS repo.
Copy link
Collaborator

@trojanobelix trojanobelix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who ever it need: Seems okay for me. :-)

@nimrof
Copy link
Collaborator

nimrof commented Aug 7, 2024

When option --edsfile is given and a xdd file was loaded a eds file is saved with the given name. This allows to have xdd as single source of truth in VCS repo.

Hi @modbw,
Thanks for taking the time to make the pr.

I am currently working on a rewrite of importer/exporter #122, as part of that work we should be able to convert any format that can be imported into anything that can be exported with edssharp

Could it be a alternative to your pr if we could export eds file from edssharp?
EDSSharp --infile something.xdd --outfile something.eds

@modbw
Copy link
Author

modbw commented Aug 7, 2024

That would totally match my requirements. Usecase is integration of EDSSharp into my CI/CD pipeline where all files except xdd are genereated. So, I need eds and md export. I have a pull request for md export ready but if you come up with a different solution thats fine. One thing would be to have multiple exports in one step to save some EDSharp calls. Something like EDSSharp --infile something.xdd --outfile something.eds --outfile something.md.

@nimrof
Copy link
Collaborator

nimrof commented Aug 9, 2024

That would totally match my requirements. Usecase is integration of EDSSharp into my CI/CD pipeline where all files except xdd are genereated. So, I need eds and md export.

Ahh, nice.
That sounds like a good idea, and is something i might use myself.
Hope to get it ready over the weekend.

I have a pull request for md export ready but if you come up with a different solution thats fine.

There are two .md generators, is it DocumentationGenMarkup or NetworkPDOreport your want?
https://github.com/CANopenNode/CANopenEditor/blob/main/libEDSsharp/DocumentationGenMarkup.cs
https://github.com/CANopenNode/CANopenEditor/blob/main/libEDSsharp/NetworkPDOreport.cs

Not sure how to do NetworkPDOreport as it needs multiple input files (or a file that contains multiple "eds") so that may take more time

One thing would be to have multiple exports in one step to save some EDSharp calls. Something like EDSSharp --infile something.xdd --outfile something.eds --outfile something.md.

I see the need, will gladly accept a pr. :)

PS: There are multiple .md exporters so you will probably need to use --type select the one that you want.

@nimrof
Copy link
Collaborator

nimrof commented Aug 11, 2024

Hi @modbw,
Waiting for comments from the others on #131, but does that work for you?

@trojanobelix
Copy link
Collaborator

Maybe it is time to close it?

@trojanobelix
Copy link
Collaborator

Closed as completed and no comment of the OP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants