Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub-Action]: Auto-formatting based on autoyapf #297

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

jonasjucker
Copy link
Contributor

@jonasjucker jonasjucker commented Oct 20, 2021

The Action introduced is as follows:

  • Every push to spack-c2sm that includes a *.py files triggers action
  • All Python files (not only those contained in commit) in spack-c2sm are checked
  • Action creates a new commit in same branch that brings all changes for Pep8-formatting
  • Action is disabled for branch master, because we don't want code changes after a merge into master

The first time the action runs, all existing files are formatted. This was done in another branch.
See #298 for the formatting changes.

@jonasjucker jonasjucker changed the title [GitHub-Action] Auto-formatting based on autoyapf [GitHub-Action]: Auto-formatting based on autoyapf Oct 20, 2021
@jonasjucker jonasjucker linked an issue Oct 20, 2021 that may be closed by this pull request
@jonasjucker
Copy link
Contributor Author

Pinging @cosunae @lxavier @elsagermann @PanicSheep @mjaehn @leclairm because this PR will modify ALL packages and Python-scripts in spack-c2sm.

Please check if modifications (only formatting) from PR #298 break anything?

@dominichofer dominichofer self-requested a review November 16, 2021 15:21
Copy link
Contributor

@dominichofer dominichofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatic pep8 formating is a well established technology. So I don't expect any breaking changes.
LGTM

@dominichofer dominichofer merged commit 44ecef5 into master Nov 16, 2021
@dominichofer dominichofer deleted the pep8_autoformat branch November 16, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

introduce pip8 style guide
2 participants