Test GTIR-DaCe backend #638
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run dace |
philip-paul-mueller
added a commit
to philip-paul-mueller/gt4py
that referenced
this pull request
Jan 15, 2025
The bug was because the `DistributedBufferRelocator` transformation did not check if its insertion would create a read-write conflict. This commit adds such a check, that is, however, not very sophisticated and needs some improvements. However, the example /`model/atmosphere/dycore/tests/dycore_stencil_tests/test_compute_exner_from_rhotheta.py`) where it surfaced, does hold more challenges. The main purpose of this commit is to unblock further development in ICON4Py. Link to ICON4Py PR: C2SM/icon4py#638
|
The GT4Py PR should solve the issue with |
philip-paul-mueller
added a commit
to GridTools/gt4py
that referenced
this pull request
Jan 16, 2025
This PR fixes an error that was reported by Edoardo (@edopao). The bug was because the `DistributedBufferRelocator` transformation did not check if its insertion would create a read-write conflict. This commit adds such a check, that is, however, not very sophisticated and needs some improvements. However, the example /`model/atmosphere/dycore/tests/dycore_stencil_tests/test_compute_exner_from_rhotheta.py`) where it surfaced, does hold more challenges. The main purpose of this PR is to unblock further development in ICON4Py. Link to ICON4Py PR: C2SM/icon4py#638
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
philip-paul-mueller
added a commit
to GridTools/gt4py
that referenced
this pull request
Jan 17, 2025
) NestedSDFG essentially allows to perform some slices, there are technically three chases: - The data container on the inside has a smaller rank than the one on the outside, thus some dimensions were removed. - The data container on the inside has the same rank than the one on the outside. - The data container on the inside has a larger rank than the one on the outside, thus some dimensions were added. The last case is not handled, as it does not happens in GT4Py. Before, the first and second case were handled together, but it was realized that the second case was not implemented properly and it was added explicitly. This PR fixes the issues with `TestFusedVelocityAdvectionStencil1To7` and `TestFusedVelocityAdvectionStencil8To13` in [ICON4Py#638](C2SM/icon4py#638), however, the later test now fails with a segmentation fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issues:
concat_whereneeded inTestFusedVelocityAdvectionStencil15To18, test marked asxfailatmosphere/advectionmodule, all stencil tests temporarily disabledBlocking issues:
test_fused_velocity_advection_stencil_1_to_7.py::TestFusedVelocityAdvectionStencil1To7::test_TestFusedVelocityAdvectionStencil1To7_benchmark[backend=dace_gpu-grid=icon_grid] - ValueError: Failed to compute the inner strides.test_fused_velocity_advection_stencil_8_to_13.py::TestFusedVelocityAdvectionStencil8To13::test_TestFusedVelocityAdvectionStencil8To13_benchmark[backend=dace_gpu-grid=icon_grid] - ValueError: Failed to compute the inner strides.test_compute_exner_from_rhotheta.py::TestComputeExnerFromRhotheta::test_TestComputeExnerFromRhotheta[backend=dace_gpu-grid=simple_grid] - AssertionError: Validation failed for 'theta_v'tests/dycore_tests(never tested before with dace backend)Depends on latest GT4Py main branch + lowering of scan PR (GridTools/gt4py#1776).