Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced customized markers for backend errors #636

Merged
merged 85 commits into from
Jan 31, 2025
Merged

Introduced customized markers for backend errors #636

merged 85 commits into from
Jan 31, 2025
+129 −75

Conversation

nfarabullini
Copy link
Contributor

@nfarabullini nfarabullini commented Jan 9, 2025 •
edited
Loading

setting embedded as default backend and related edits

@nfarabullini nfarabullini marked this pull request as draft January 9, 2025 11:02
@nfarabullini
first batch of edits
d19426e
@nfarabullini
Merge branch 'main' of https://github.com/C2SM/icon4py into embedded_…
ddf7519 
…backend_config
@nfarabullini
further edits
372d3d8
@nfarabullini
diffusion and velocity_advection stencils edits
35a0d1b
@nfarabullini
small edit
f77d760
@nfarabullini
dycore stencils edits
855a527
@nfarabullini
small edit
3c861c3
@nfarabullini
further edits
7210aeb
@nfarabullini
small edits to xfail message
3b559f5
@nfarabullini
ran pre-commit
f8bcc3b
@nfarabullini
small import edit
1d0a849
@nfarabullini
Merge branch 'main' of https://github.com/C2SM/icon4py into embedded_…
b683621 
…backend_config
@nfarabullini
small edit
45df53f
@nfarabullini
added embedded_skip markers to velocity_advection and solvenonhydro
04bce82
@nfarabullini
small edits to register_key
7eeb6f7
@nfarabullini
edits to fused stencil tests
0f0605a
@nfarabullini
small fix
b6f9134
@nfarabullini
further addition of skip for embedded
377beeb
@nfarabullini
fixed type
727926d
@nfarabullini
Update test_apply_diffusion_to_w_and_compute_horizontal_gradients_for…
d6999d8 
…_turbulence.py

commented out marker
@nfarabullini
removved skip if statements
062eaba
@nfarabullini
added marker for missing neighbors
15e9e4b
@nfarabullini
testing edits
5387e73
@nfarabullini
small edit
055989c
@nfarabullini
small edit
113b873
@nfarabullini
various edits
ecefd0b
@nfarabullini
added marker
2371ac2
@nfarabullini
small edit
0d6973d
@nfarabullini
Copy link
Contributor Author

cscs-ci run default

@nfarabullini nfarabullini requested a review from havogt January 29, 2025 08:52
havogt
havogt requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a problem with the type of backend, sometimes it is str, sometimes Backend.

model/testing/src/icon4py/model/testing/helpers.py Outdated Show resolved Hide resolved
model/testing/src/icon4py/model/testing/helpers.py Outdated Show resolved Hide resolved
model/testing/src/icon4py/model/testing/helpers.py Outdated Show resolved Hide resolved
model/testing/src/icon4py/model/testing/helpers.py Show resolved Hide resolved
model/testing/src/icon4py/model/testing/pytest_config.py Outdated Show resolved Hide resolved
model/testing/src/icon4py/model/testing/helpers.py Outdated Show resolved Hide resolved
model/testing/src/icon4py/model/testing/helpers.py
pytest.xfail("Embedded backend does not support as_offset.")
case "requires_concat_where" if is_embedded(param):
pytest.xfail("Stencil requires concat_where.")
case "skip_value_error":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Regarding 2 I would not run them by default in CI as it creates the mismatch between PR run and daily run. And also I prefer to run benchmarks on things that we verified.

Regarding 1, I would rather prioritize getting rid of the skip_value_error marker in a next PR if that that's ok for you. It seems it's anyway part of what @halungge wanted to do in https://hackmd.io/s1iBcbqiR6CpJ0XfJHRAnQ (I added a link to this tag there).

@nfarabullini nfarabullini requested a review from havogt January 30, 2025 08:15
nfarabullini and others added 2 commits January 30, 2025 18:27
@nfarabullini @havogt
Update model/testing/src/icon4py/model/testing/helpers.py
5cb1c1e 
Co-authored-by: Hannes Vogt <hannes@havogt.de>
@nfarabullini @havogt
Update model/testing/src/icon4py/model/testing/helpers.py
9ace851 
Co-authored-by: Hannes Vogt <hannes@havogt.de>
@nfarabullini nfarabullini changed the title embedded backend config edits Introduced customized markers for backend errors Jan 30, 2025
@nfarabullini
Copy link
Contributor Author

cscs-ci run default

havogt
havogt approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Maybe add a note in the commit message on what to do if you need to add a new exclusion case for a backend.

@github-actions GitHub Actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@nfarabullini
Copy link
Contributor Author

cscs-ci run default

@nfarabullini nfarabullini merged commit 9bab5b1 into main Jan 31, 2025
3 checks passed
@edopao edopao mentioned this pull request Jan 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edopao edopao edopao left review comments

@havogt havogt havogt approved these changes

@egparedes egparedes Awaiting requested review from egparedes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfarabullini @havogt @edopao