-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove zero stencils from dycore/state_utils/utils.py #425
Conversation
remove idiv_method from SolveNonHydroConfig
cscs-ci run default |
cscs-ci run default |
cscs-ci run default |
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
launch jenkins spack |
cscs-ci run default |
model/atmosphere/dycore/src/icon4py/model/atmosphere/dycore/state_utils/utils.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just had one comment
- remove zero stencils from dycore/state_utils/utils.py - remove idiv_method from SolveNonHydroConfig
- remove zero stencils from dycore/state_utils/utils.py - remove idiv_method from SolveNonHydroConfig
idiv_method
fromSolveNonHydroConfig
as the namelist option was removed in ICONdatatest
for interpolation fields:- restrict verification of internal fields in predictor step to the domain calculated