Clean up SimpleGridData e2c2v field #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, this is jenkins continuous integration... |
1 similar comment
|
Hi there, this is jenkins continuous integration... |
|
launch jenkins spack |
|
Opened #432 since the CI is not working on this PR due to opening it from a fork |
iomaganaris
added a commit
that referenced
this pull request
Apr 8, 2024
OngChia
pushed a commit
that referenced
this pull request
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2c2v_tableinSimpleGridDatahad an error for edge#26based on the torus representation in https://github.com/c2sm/icon4py/blob/main/model/common/src/icon4py/model/common/grid/simple.py#L56diamond_tablewas a duplicate ofe2c2v_tablewithout the issue so I've replaced the data ofe2c2v_tablewith the data ofdiamond_tableand removeddiamond_tablepytest: