Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stencil test classes names #391

Merged
merged 45 commits into from
Apr 15, 2024
Merged

Fix stencil test classes names #391

merged 45 commits into from
Apr 15, 2024

Conversation

huppd
Copy link
Contributor

@huppd huppd commented Feb 21, 2024

This PR fixes the test class names to be up to date with the new stencil names.

@huppd
Copy link
Contributor Author

huppd commented Feb 21, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Feb 21, 2024

launch jenkins spack

halungge
halungge requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some typos which are already in the stencil names.

...osphere/dycore/tests/dycore_stencil_tests/test_add_extra_diffusion_for_wn_approaching_cfl.py Outdated Show resolved Hide resolved
model/atmosphere/dycore/tests/dycore_stencil_tests/test_compute_graddiv2_of_vn.py Outdated Show resolved Hide resolved
...sts/dycore_stencil_tests/test_interpolate_contravatiant_vertical_verlocity_to_full_levels.py Outdated Show resolved Hide resolved
model/atmosphere/dycore/tests/dycore_stencil_tests/test_interpolate_vt_to_ie.py Outdated Show resolved Hide resolved
model/atmosphere/dycore/tests/dycore_stencil_tests/test_set_cell_kdim_field_to_zero_vp.py Outdated Show resolved Hide resolved
model/atmosphere/dycore/tests/dycore_stencil_tests/test_update_densety_exener_wind.py Outdated Show resolved Hide resolved
...ore_stencil_tests/test_compute_horizontal_gradient_of_extner_pressure_for_multiple_levels.py Outdated Show resolved Hide resolved
...dycore/tests/dycore_stencil_tests/test_compute_pertubation_of_rho_and_theta_and_rho_at_ic.py Outdated Show resolved Hide resolved
@huppd
Copy link
Contributor Author

huppd commented Feb 23, 2024

@halungge thanks for the valuable feedback. I think some of the changes are a bit out of the scope of this PR, but I am happy to do them. But as this requires also changes in icon-exclaim. I put this on hold till the freeze is over.

@huppd
Copy link
Contributor Author

huppd commented Feb 27, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Feb 27, 2024

launch jenkins spack

@huppd
Copy link
Contributor Author

huppd commented Mar 4, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Mar 4, 2024

launch jenkins spack

halungge
halungge requested changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@halungge halungge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniel. I found another typo that I did not spot in the last review. You might fix that as well, I added some other remarks but I can live with them except for that typo, once you are at it.

I am sorry this triggered an PR in icon-exclaim as well...

model/docs/stencil_naming_convention.md Outdated Show resolved Hide resolved
model/atmosphere/advection/tests/stencil_tests/test_return_zero_c.py Outdated Show resolved Hide resolved
...del/atmosphere/dycore/compute_pertubation_of_rho_and_theta_and_rho_interface_cell_centers.py Outdated Show resolved Hide resolved
@halungge halungge mentioned this pull request Mar 8, 2024
Closed
@huppd
Copy link
Contributor Author

huppd commented Apr 10, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Apr 10, 2024

launch jenkins spack

@huppd
Copy link
Contributor Author

huppd commented Apr 10, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Apr 11, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Apr 11, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Apr 11, 2024

launch jenkins spack

@halungge halungge self-requested a review April 12, 2024 08:55
halungge
halungge reviewed Apr 12, 2024
View reviewed changes
Copy link
Contributor

@halungge halungge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. Please check for the init_zerostencils in dycore/state_utils I think they were removed from main and are not longer needed.

model/atmosphere/dycore/src/icon4py/model/atmosphere/dycore/state_utils/utils.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check wether those are actually used. I switched to the corresponding stencils from model/atmosphere/dycore/ in SolveNonHydro, and deleted most of them from this module, since they are duplicates. So you might re-introduce something that is not used anywhere.

@huppd
Copy link
Contributor Author

huppd commented Apr 12, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Apr 12, 2024

launch jenkins spack

@huppd
Copy link
Contributor Author

huppd commented Apr 12, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Apr 12, 2024

cscs-ci run default

@github-actions GitHub Actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@huppd
Copy link
Contributor Author

huppd commented Apr 12, 2024

cscs-ci run default

@huppd
Copy link
Contributor Author

huppd commented Apr 12, 2024

launch jenkins spack

@huppd huppd merged commit 47ab0ae into main Apr 15, 2024
5 checks passed
iomaganaris referenced this pull request in iomaganaris/icon4py Jun 18, 2024
@huppd @iomaganaris
Fix stencil test classes names (#391)
504cc5c 
This PR fixes the test class names to be up to date with the new stencil names.
@samkellerhals samkellerhals deleted the fix_stencil_test_names branch December 20, 2024 08:36
OngChia pushed a commit that referenced this pull request Jan 14, 2025
@huppd
Fix stencil test classes names (#391)
68fd192 
This PR fixes the test class names to be up to date with the new stencil names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halungge halungge halungge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huppd @halungge