Enable optional stencils and modules in Liskov
#358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o optional_modules_liskov
|
cscs-ci run default |
|
launch jenkins spack |
|
launch jenkins spack |
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run default |
1 similar comment
|
cscs-ci run default |
…n4py into optional_modules_liskov
|
cscs-ci run default |
|
cscs-ci run default |
2 similar comments
|
cscs-ci run default |
|
cscs-ci run default |
|
cscs-ci run default |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
launch jenkins spack |
|
launch jenkins icon |
samkellerhals
approved these changes
May 15, 2024
iomaganaris
referenced
this pull request
in iomaganaris/icon4py
Jun 18, 2024
This PR allows to integrate optional stencils using Liskov. The GT4Py stencils are ignored if their module e.g. advection is not specified explicitly at compilation. The motivation for this feature is that the performance of some modules (e.g. advection and graupel) is not yet satisfying but keeping them in a separate branch is a lot of overhead.
More specifically this PR:
adds a new argument parameter optional_module to the START STENCIL liskov directive to specify which optional module the stencil belongs to, e.g. optional_module=advection.
adds a new option --enable_optional_stencil to the liskov CLI to enable the optional stencils and specify which module. e.g. --enable_optional_stencil=advection. Corresponding PR in icon-exclaim adds the changes in the icon_liskov preprocessor command in configure and CMakelist.txt.
---------
Co-authored-by: Nina Burgdorfer <Nina.Burgdorfer@meteoswiss.ch>
Co-authored-by: samkellerhals <kellerhalssamuel@gmail.com>
Co-authored-by: Daniel Hupp <daniel.hupp@meteoswiss.ch>
Co-authored-by: Nicoletta Farabullini <41536517+nfarabullini@users.noreply.github.com>
OngChia
pushed a commit
that referenced
this pull request
Jan 14, 2025
This PR allows to integrate optional stencils using Liskov. The GT4Py stencils are ignored if their module e.g. advection is not specified explicitly at compilation. The motivation for this feature is that the performance of some modules (e.g. advection and graupel) is not yet satisfying but keeping them in a separate branch is a lot of overhead.
More specifically this PR:
adds a new argument parameter optional_module to the START STENCIL liskov directive to specify which optional module the stencil belongs to, e.g. optional_module=advection.
adds a new option --enable_optional_stencil to the liskov CLI to enable the optional stencils and specify which module. e.g. --enable_optional_stencil=advection. Corresponding PR in icon-exclaim adds the changes in the icon_liskov preprocessor command in configure and CMakelist.txt.
---------
Co-authored-by: Nina Burgdorfer <Nina.Burgdorfer@meteoswiss.ch>
Co-authored-by: samkellerhals <kellerhalssamuel@gmail.com>
Co-authored-by: Daniel Hupp <daniel.hupp@meteoswiss.ch>
Co-authored-by: Nicoletta Farabullini <41536517+nfarabullini@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to integrate optional stencils using Liskov. The GT4Py stencils are ignored if their module e.g. advection is not specified explicitly at compilation. The motivation for this feature is that the performance of some modules (e.g. advection and graupel) is not yet satisfying but keeping them in a separate branch is a lot of overhead.
More specifically this PR:
optional_moduleto theSTART STENCILliskov directive to specify which optional module the stencil belongs to, e.g.optional_module=advection.--enable_optional_stencilto the liskov CLI to enable the optional stencils and specify which module.e.g. --enable_optional_stencil=advection. Corresponding PR in icon-exclaim adds the changes in theicon_liskovpreprocessor command inconfigureandCMakelist.txt.