-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test dependencies on savepoints #349
Conversation
cscs-ci run default |
launch jenkins spack |
cscs-ci run benchmark |
cscs-ci run default |
launch jenkins spack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
cscs-ci run default |
launch jenkins spack |
launch jenkins spack |
cscs-ci run default |
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
cscs-ci run default |
launch jenkins spack |
cscs-ci run default |
(cleanup) Make test_solve_nonhydro.py indenpendent of `VelocityInitSavepoint`.
Make
test_solve_nonhydro.py
indenpendent ofVelocityInitSavepoint
read all necessary fields fromIconNonHydroInitSavepoint
instead.