Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test dependencies on savepoints #349

Merged
merged 12 commits into from
Feb 6, 2024

Conversation

halungge
Copy link
Contributor

Make test_solve_nonhydro.py indenpendent of VelocityInitSavepoint read all necessary fields from IconNonHydroInitSavepoint instead.

@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge
Copy link
Contributor Author

cscs-ci run benchmark

@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

launch jenkins spack

@halungge halungge requested a review from abishekg7 January 11, 2024 09:56
Copy link
Contributor

@abishekg7 abishekg7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@halungge
Copy link
Contributor Author

halungge commented Feb 2, 2024

cscs-ci run default

@halungge
Copy link
Contributor Author

halungge commented Feb 2, 2024

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

cscs-ci run default

Copy link

github-actions bot commented Feb 6, 2024

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

cscs-ci run default

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

launch jenkins spack

@halungge
Copy link
Contributor Author

halungge commented Feb 6, 2024

cscs-ci run default

@halungge halungge merged commit a5c8e18 into main Feb 6, 2024
5 checks passed
@halungge halungge deleted the fix_test_dependencies_on_savepoints branch December 12, 2024 07:01
OngChia pushed a commit that referenced this pull request Jan 14, 2025
(cleanup) Make test_solve_nonhydro.py indenpendent of `VelocityInitSavepoint`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants