Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add non_hydro_39_40 #295

Merged
merged 9 commits into from
Oct 25, 2023
Merged

Add non_hydro_39_40 #295

merged 9 commits into from
Oct 25, 2023

Conversation

samkellerhals
Copy link
Contributor

No description provided.

@samkellerhals samkellerhals marked this pull request as draft October 18, 2023 12:37
@samkellerhals
Copy link
Contributor Author

cscs-ci run

@samkellerhals
Copy link
Contributor Author

cscs-ci run

@samkellerhals samkellerhals requested a review from muellch October 20, 2023 13:21
@samkellerhals
Copy link
Contributor Author

cscs-ci run

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

@samkellerhals
Copy link
Contributor Author

cscs-ci run

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run
  • launch jenkins spack

Optional Tests

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@samkellerhals
Copy link
Contributor Author

cscs-ci run

@samkellerhals
Copy link
Contributor Author

launch jenkins spack

muellch
muellch approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@muellch muellch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just interested why you needed to create all of those __init__.py files? Did they not already exist?

@samkellerhals
Copy link
Contributor Author

Looks good! Just interested why you needed to create all of those __init__.py files? Did they not already exist?

They did not, and somehow it caused import errors when running pytest without them.

@samkellerhals samkellerhals marked this pull request as ready for review October 25, 2023 09:34
@samkellerhals samkellerhals merged commit 22aa274 into main Oct 25, 2023
@samkellerhals samkellerhals deleted the fuse-non-hydro-39-40 branch October 25, 2023 09:34
OngChia pushed a commit that referenced this pull request Jan 14, 2025
@samkellerhals
Add non_hydro_39_40 (#295)
f09d869 
Add non_hydro_39_40 fused stencil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muellch muellch muellch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samkellerhals @muellch