Fix test references (assuming wrap around) #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
launch jenkins spack |
|
launch jenkins icon |
|
launch jenkins spack spackProject=halungge/icon4py-merge-greenline-in-main |
Merged
|
launch jenkins spack spackProject=C2SM/icon4py_rebase |
samkellerhals
approved these changes
Sep 19, 2023
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
ninaburg
pushed a commit
that referenced
this pull request
Sep 27, 2023
This fixes test references where the current implementation assumes a certain behavior of the backend. Specifically, we used np.roll in the references and the backend (by chance) had the same wrap-around behavior. For an upcoming PR in GT4Py, we need to remove that expectation. --------- Co-authored-by: Jonas Jucker <jonas.jucker@c2sm.ethz.ch> Co-authored-by: juckerj <39263956+jonasjucker@users.noreply.github.com> Co-authored-by: Abishek Gopal <abishek.gopal@c2sm.ethz.ch>
OngChia
pushed a commit
that referenced
this pull request
Jan 14, 2025
This fixes test references where the current implementation assumes a certain behavior of the backend. Specifically, we used np.roll in the references and the backend (by chance) had the same wrap-around behavior. For an upcoming PR in GT4Py, we need to remove that expectation. --------- Co-authored-by: Jonas Jucker <jonas.jucker@c2sm.ethz.ch> Co-authored-by: juckerj <39263956+jonasjucker@users.noreply.github.com> Co-authored-by: Abishek Gopal <abishek.gopal@c2sm.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some (not all) references where the current implementation assumes a certain behavior of the backend.
Specifically, we used np.roll in the references and the backend (by chance) had the same wrap-around behavior. For an upcoming PR in GT4Py, we need to remove that expectation.